mitre88 commented on PR #70488: URL: https://github.com/apache/airflow/pull/70488#issuecomment-5147959429
@shahar1 Done — the PR is now scoped to `GCSFileTransformOperator` only and rebased on current `main` (which includes #70505). To confirm the remaining change is consistent with the #70505 distinction: `destination_bucket or self.source_bucket` is a truthiness/value read of the unrendered template parameter, **not** an argument-provision check (`is None`/`is not None`), so it is not covered by the new sanctioned pattern — the exemption entry only stays valid if the fallback moves out of `__init__`. That's what this PR does: - `__init__` now stores `destination_bucket`/`destination_object` verbatim (no read of the unrendered value). - The `or source_*` fallback resolves in `execute()`, after rendering. - `get_openlineage_facets_on_complete` (which can run outside `execute`) resolves the fallbacks locally. - The `GCSFileTransformOperator` exemption entry is removed; `validate_operators_init.py` passes on the file (exit 0). Everything else from the earlier revision (`GCSDeleteObjectsOperator`, `GCSListObjectsOperator`, their exemption entries) was dropped. --- Drafted-by: Claude Code (Fable 5) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
