sortega commented on code in PR #70517:
URL: https://github.com/apache/airflow/pull/70517#discussion_r3776361893
##########
shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py:
##########
@@ -158,9 +159,10 @@ def timer(
def get_statsd_logger(
*,
- stats_class: type[StatsClient],
+ stats_class: type[StatsClient] | type[UnixSocketStatsClient] | None = None,
Review Comment:
~~The current code has a `issubclass` check. Allowing `Callable` will be
moot as we require the subclassing. Do you want to drop that check?~~
Allowing the callable was a mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
