uranusjr commented on code in PR #70517:
URL: https://github.com/apache/airflow/pull/70517#discussion_r3800265961
##########
task-sdk/src/airflow/sdk/observability/metrics/statsd_logger.py:
##########
@@ -23,32 +23,49 @@
from airflow.sdk._shared.observability.metrics import statsd_logger
from airflow.sdk.configuration import conf
+log = logging.getLogger(__name__)
+
if TYPE_CHECKING:
from airflow.sdk._shared.observability.metrics.statsd_logger import
SafeStatsdLogger
-log = logging.getLogger(__name__)
-
def get_statsd_logger() -> SafeStatsdLogger:
- stats_class = conf.getimport("metrics", "statsd_custom_client_path",
fallback=None)
+ # Local import to avoid requiring statsd when other backends are used
(e.g. Datadog)
+ from statsd import StatsClient, UnixSocketStatsClient
- # no need to check for the scheduler/statsd_on -> this method is only
called when it is set
- # and previously it would crash with None is callable if it was called
without it.
- from statsd import StatsClient
+ socket_path = conf.get("metrics", "statsd_socket_path", fallback=None)
+ custom_class = conf.getimport("metrics", "statsd_custom_client_path",
fallback=None)
- if stats_class:
- if not issubclass(stats_class, StatsClient):
+ if custom_class is not None:
+ if socket_path is not None:
+ if not (isinstance(custom_class, type) and
issubclass(custom_class, UnixSocketStatsClient)):
+ raise AirflowConfigException(
+ "Your custom StatsD client must extend the
statsd.UnixSocketStatsClient "
+ "when using a socket path in order to ensure backwards
compatibility."
+ )
+ elif not (
+ isinstance(custom_class, type) and issubclass(custom_class,
(StatsClient, UnixSocketStatsClient))
Review Comment:
I don’t think this is right? When we reach here, `socket_path` is not None,
so UnixSocketStatsClient should not be checked here?
Also, the `isinstance(custom_class, type)` part seems excessive. A non-type
input here would simply cause a `TypeError` on `issubclass`, which would be
clean enough for users to know they should have passed in a type. This is also
documented anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
