xBis7 commented on PR #70517: URL: https://github.com/apache/airflow/pull/70517#issuecomment-5314135654
@sortega Thanks for updating the PR! If you need a new type exception it needs to be added here instead of adding a new dependency https://github.com/sortega/airflow/blob/sortega/DNAWF-4497_dd_dogstats_url/shared/observability/src/airflow_shared/observability/exceptions.py But, I don't think we should do that. `airflow-core` and `task-sdk` both initialize their own config parser and then re-use some parts from`shared/configuration`. Because the `conf` object is different for these main packages, config is read twice under `airflow-core` and `task-sdk` and then passed to `shared`. E.g. https://github.com/apache/airflow/pull/70517/changes#diff-8a528bc2492e4fcc8361aeb91b6014d77b09d1ad190c3f75a7d9b8f087ddc6bcR33 https://github.com/apache/airflow/pull/70517/changes#diff-fba7485cf1bc00467f34ed32e234b40b630fe7f0ff52df832d27f4c10b679418R34 So, if you need to do a validation which will throw an `AirflowConfigException`, then that should happen in the factory methods and then the validated value should be passed to the shared code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
