divyanshus2404 commented on PR #71711: URL: https://github.com/apache/airflow/pull/71711#issuecomment-5412169950
Added unit tests covering each form the parser handles — `key=value`, dotted and uppercase keys, space-separated values, multi-token quoted values, and a sensitive flag with no following value — plus a large-input test guarding against a regression to the original quadratic behaviour. While writing them I ran the new parser differentially against the old regex and found two masking gaps in my first implementation: | input | before this PR | first implementation | |---|---|---| | `password hunter2` (repeated spaces) | `password ******` | `password ****** hunter2` | | `--password<TAB>hunter2` | `--password<TAB>******` | not masked | Splitting on a single literal space meant a run of spaces produced an empty field that was consumed as the value, and a tab never split at all. Both leak through `_submit_log_tail`, which masks raw spark-submit output where column-aligned spacing is common. Fixed in 2fa05d9 by splitting on runs of whitespace and keeping the separators, with regression tests for both shapes. This also preserves the original spacing instead of normalising it. Full spark provider suite passes (271 passed, 2 skipped). --- Drafted-by: Claude Code (Opus 5) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
