divyanshus2404 commented on PR #71711: URL: https://github.com/apache/airflow/pull/71711#issuecomment-5412220942
Thanks — tests added in 0dc1ddf. `test_masks_passwords` now covers each form the parser handles: `key=value`, dotted and uppercase keys, space-separated values, values quoted across multiple tokens, and a sensitive flag with no following value. `test_masks_passwords_is_linear_on_large_input` guards the quadratic behaviour this PR removes. 2fa05d9 hardens the split to handle tab- and multi-space-separated values, which `_submit_log_tail` encounters in column-aligned spark-submit output; regression cases for both are included. Splitting on whitespace runs and preserving the separators also keeps the original spacing intact rather than normalising it. Verified against the previous regex over 60k generated command lines with no output differences, so masking behaviour is unchanged. Full spark provider suite: 271 passed, 2 skipped. --- Drafted-by: Claude Code (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
