FrankYang0529 commented on code in PR #73426: URL: https://github.com/apache/airflow/pull/73426#discussion_r4062048114
########## go-sdk/airflow/bundle.go: ########## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package airflow + +import ( + "fmt" + "sync" + + "github.com/apache/airflow/go-sdk/internal/bundlev1" +) + +// BundleRef holds the task handlers that this executable runs for Airflow. +// [Bundle] returns an empty one. +type BundleRef struct { + tasks taskMap +} + +// Bundle returns an empty bundle. Register the task handlers on it, then call Serve as the +// last statement of main: +// +// func main() { +// bundle := airflow.Bundle() +// +// bundle.Register( +// airflow.TaskHandler("py_etl", "transform", transform), +// ) +// +// if err := bundle.Serve(); err != nil { +// log.Fatal(err) +// } +// } +func Bundle() *BundleRef { return &BundleRef{} } + +// Registraterable is what [BundleRef.Register] accepts. [TaskHandler] returns one. +// +// Its only method is unexported, so a type outside this package cannot declare it. +// A struct that embeds a Registraterable still satisfies the interface, and Register panics +// when it is given one. +type Registraterable interface{ registraterable() } + +// Register adds items to the bundle. +// +// A package that defines task handlers can return them as a []Registraterable, +// and main passes that slice as bundle.Register(pkg.Handlers()...). +// +// Register panics if a task handler with the same dag_id and task_id is already registered. +func (b *BundleRef) Register(items ...Registraterable) { + for _, item := range items { + switch item := item.(type) { + case *taskHandler: + b.tasks.add(item.dagId, item.taskId, item.task) + default: + // Either a nil item, or a struct from another package that embeds a Registraterable. + panic(fmt.Sprintf("airflow.BundleRef.Register: cannot register %T", item)) + } + } +} + +// taskMap holds the registered tasks by dag_id and task_id. +// It also keeps registration order. The --airflow-metadata manifest lists the tasks of each Dag +// in that order. +type taskMap struct { + mu sync.RWMutex + tasks map[string]map[string]bundlev1.Task Review Comment: Changed `taskMap ` to `taskHandlerMap`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
