FrankYang0529 commented on code in PR #73426:
URL: https://github.com/apache/airflow/pull/73426#discussion_r4062053937
##########
go-sdk/internal/bundlev1/task.go:
##########
@@ -31,18 +31,38 @@ import (
)
// Task is one registered task that the coordinator runtime can execute. Bundle
-// authors do not implement this directly; Dag.AddTask wraps a plain Go
+// authors do not implement this directly. airflow.TaskHandler wraps a plain Go
// function into a Task.
type Task interface {
Execute(ctx context.Context, logger *slog.Logger, args []binding.Arg)
error
}
-// Bundle is the execution-time view of a registry. It looks up a task by
-// dag_id and task_id.
+// Bundle looks up a registered task by dag_id and task_id. The coordinator
+// runtime uses Bundle to find the task the supervisor asked for.
type Bundle interface {
LookupTask(dagId, taskId string) (Task, bool)
}
+// TaskInfo describes a registered task by its user-visible id.
+type TaskInfo struct {
+ ID string
+}
+
+// DagInfo describes a registered dag together with its tasks in
+// registration order.
+type DagInfo struct {
+ DagID string
+ Tasks []TaskInfo
+}
Review Comment:
Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
