FrankYang0529 commented on code in PR #73426:
URL: https://github.com/apache/airflow/pull/73426#discussion_r4062073461
##########
go-sdk/pkg/execution/metadata.go:
##########
@@ -62,39 +62,25 @@ func ParseMetadataFormat(s string) (MetadataFormat, error) {
}
}
-// DumpAirflowMetadata writes the bundle's airflow-metadata manifest to stdout
-// (YAML by default, JSON when format is MetadataFormatJSON). It runs
-// RegisterDags against an in-memory recorder only — no task execution, no
external
-// services. airflow-go-pack execs the binary with --airflow-metadata and
-// decodes this output to build the embedded manifest.
-func DumpAirflowMetadata(bundle bundlev1.BundleProvider, format
MetadataFormat) error {
- meta, err := collectManifest(bundle)
+// DumpAirflowMetadata writes the bundle's airflow-metadata manifest to w
Review Comment:
The first line ended with `to w`, where `w` is the `io.Writer` parameter, so
it looked truncated in the diff. I reworded the sentence so that no line ends
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
