amoghrajesh commented on code in PR #73030:
URL: https://github.com/apache/airflow/pull/73030#discussion_r4070345050
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Details.tsx:
##########
@@ -162,6 +202,12 @@ export const Details = () => {
</Flex>
</Table.Cell>
</Table.Row>
+ {tryInstance?.state_reason === null || tryInstance?.state_reason ===
undefined ? undefined : (
Review Comment:
Both now use the same list of states, kept in one place so they cannot drift
apart again. Thats what let them get out of sync in the first place.
One difference from your suggestion: the row checks the selected try's
state, not the task's. If it used the task's state, picking an older failed try
while the task is running again would hide that try's reason, which is the
whole point of the row. Your suggested assertion passes either way, so I added
a test that tells the two apart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
