uranusjr commented on code in PR #74230:
URL: https://github.com/apache/airflow/pull/74230#discussion_r4203823496
##########
java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/internal/Refs.kt:
##########
@@ -57,9 +59,30 @@ object Refs {
dag: DagDef,
taskIds: List<String>,
depends: Runnable,
+ ): DagDef = record(dag, taskIds, emptyList(), emptyMap(), depends)
+
+ /**
+ * Runs one `depends()` call as [record] does, for a Dag whose tasks sit in
+ * task groups.
+ *
+ * @param groupIds Full ID of every task group, parents before the groups
+ * nested in them. All are created before `depends()` runs, so the wiring
+ * can order a group before calling any of its tasks, and a group holding
+ * no tasks still exists.
Review Comment:
groupIds is documented as "parents before the groups nested in them", but
ensureGroup also recurses to create missing parents. Keep one of the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
