uranusjr commented on code in PR #74230:
URL: https://github.com/apache/airflow/pull/74230#discussion_r4203831037
##########
java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/internal/Refs.kt:
##########
@@ -116,7 +139,40 @@ object Refs {
}
inputs.filterIsInstance<TaskRef<*>>().forEach { def.dependsOn(it.def) }
def.inputs += inputs
- active.dag.addTask(def)
+ val group = active.groupOf[def.id]
Review Comment:
The generated group view already knows its group id. Have its task methods
pass it, e.g. `Refs.node(groupId(), def)`, so the `Map.ofEntries` in the
builder and the second record overload can go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
