uranusjr commented on code in PR #74230:
URL: https://github.com/apache/airflow/pull/74230#discussion_r4203874248
##########
java-sdk/processor/src/main/kotlin/org/apache/airflow/sdk/BuilderProcessor.kt:
##########
@@ -717,13 +896,19 @@ private val REFS_TYPE = ClassName.get(Refs::class.java)
private val ARG_TYPE = ClassName.get(Arg::class.java)
private val TASK_HANDLE_TYPE = ClassName.get(TaskRef::class.java)
private val DEPS_TYPE = ClassName.get(Deps::class.java)
+private val GROUP_TYPE = ClassName.get(Group::class.java)
+private val LIST_TYPE = ClassName.get(List::class.java)
+private val MAP_TYPE = ClassName.get(Map::class.java)
+
+private val GROUP_ID = Regex("[A-Za-z0-9_-]+")
private const val DAG_ANNOTATION = "org.apache.airflow.sdk.Builder.Dag"
private const val TASK_ANNOTATION = "org.apache.airflow.sdk.Builder.Task"
private val RESERVED_VIEW_NAMES =
setOf(
"depends",
+ "group",
Review Comment:
Is this needed? Neither Deps nor Dag has this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
