SEPURI-SAI-KRISHNA commented on issue #74459:
URL: https://github.com/apache/airflow/issues/74459#issuecomment-6073264334

   Tested both of the changes I am listed for. Both work as expected.
   
   Environment: clean virtualenv on Python 3.11, installed from PyPI, 
`apache-airflow` 3.3.2. No dbt Cloud account or GCP project involved, since 
everything below is observable before the first API call. In each case I also 
checked the previous stable release to confirm the result depends on the change 
rather than passing either way.
   
   **dbt.cloud 4.11.0rc1, [Apply hook_params to deferred dbt Cloud job runs 
(#74199)](https://github.com/apache/airflow/pull/74199)**
   
   Walking the installed wheel, the `DbtCloudRunJobTrigger` construction in 
`operators/dbt.py` now passes `hook_params`; on `4.10.0` it does not. In both 
releases the trigger already accepted it, kept it across `serialize()` and 
built its hook with `**self.hook_params`, so the operator's call site was the 
only gap and nothing else had to change.
   
   | | 4.10.0 | 4.11.0rc1 |
   | --- | --- | --- |
   | `hook_params` passed at the defer site | absent | present |
   
   Checked at runtime with `hook_params={"retry_limit": 7, "retry_delay": 
3.5}`: the operator retains them, its own hook honours them, and a trigger 
built with them serializes them intact.
   
   **google 22.7.0rc1, [Apply impersonation_chain to deferred BigQuery 
existence checks (#71648)](https://github.com/apache/airflow/pull/71648)**
   
   Both deferral sites in `sensors/bigquery.py` now pass `impersonation_chain`, 
one for `BigQueryTableExistenceTrigger` and one for 
`BigQueryTablePartitionExistenceTrigger`; on `22.6.0` neither does. As above, 
the triggers accepted and serialized the argument in both releases, so only the 
sensors needed the change.
   
   | | 22.6.0 | 22.7.0rc1 |
   | --- | --- | --- |
   | `BigQueryTableExistenceTrigger` | absent | present |
   | `BigQueryTablePartitionExistenceTrigger` | absent | present |
   
   Confirmed the trigger accepts `impersonation_chain` and serializes it as 
given.
   
   **Import smoke check**
   
   Importing every module of both providers: all 12 dbt Cloud modules import, 
and 297 of 333 google modules. The 36 that do not are all missing optional 
peers in this environment, other providers plus paramiko, kubernetes, 
apache-beam, cassandra, oracledb and similar, each failing with an explicit 
message naming what is absent. Nothing failed for a reason internal to either 
release.
   ****


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to