dhkim1920 commented on code in PR #73783:
URL: https://github.com/apache/airflow/pull/73783#discussion_r4260014407


##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########


Review Comment:
   Agreed that restoring the original numeric type does not need to be part of 
this PR. I'll keep its scope focused on transporting large integers to the task 
process.
   
   One caveat from the PostgreSQL reproduction: after a JSONB round trip, 
`1.7E308` becomes an integer that compares unequal to the original Python 
float. For example, `conf["value"] == 1.7e308` is false after reloading it. 
This can affect equality checks or dictionary lookups using the original float 
as a key.
   
   Converting that integer back to `float` gives the original float again. The 
difference is between the binary floating-point approximation and the decimal 
integer returned by JSONB; it does not establish a loss of numeric precision in 
JSONB.
   
   ---
   Drafted-by: Codex (GPT-6); reviewed by @dhkim1920 before posting
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to