dstandish commented on code in PR #74046:
URL: https://github.com/apache/airflow/pull/74046#discussion_r4298286309
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -422,6 +422,12 @@ def ti_run(
if token.claims.scope == "workload":
issue_execution_token(services, response, sub=str(task_instance_id))
+ # Emitted last for the same reason as task.queued_duration below. Every
state other than QUEUED
+ # either raised above or was a duplicate request from a running task.
Review Comment:
this comment is confusing. it says "emitted last for same reason as below"
-- well that reveals in fact that it _isn't_ emitted last -- something else
comes after it. so let's say what we really mean. meanwhile, i also think it's
unhelpful to say "same reason as below" even if it is true -- better to just be
duplicative because we aren't always going to be able to see the "below" thing
in a review, and the "below" thing might at some point get removed. as it is,
it's unclear to me what this comment is trying to tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
