dstandish commented on code in PR #74046:
URL: https://github.com/apache/airflow/pull/74046#discussion_r4298429710
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -787,6 +803,26 @@ def _build_rejected_gate_payload(
return TITerminalStatePayload(state=TerminalStateNonSuccess.FAILED,
retry_reason=reason, **carried)
+def _emit_task_finish_metrics(
Review Comment:
i'm not sure we need all of these attributes. and they can cause problems.
even on api server, you are relying on the same worker getting hit with the
same event type for the same team / operator / task / dag before the series
gets expired (if delta to cumulative) or before the worker gets cycled (if
cumulative), aren't you? otherwise you'll get non-incrementing series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
