ucaeon commented on code in PR #73591:
URL: https://github.com/apache/airflow/pull/73591#discussion_r4310745597
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_kustomize_commands.py:
##########
@@ -539,6 +595,8 @@ def _smoke_test_overlay_impl(
console_print("[error]verify block failed.")
return 1
console_print("\n[success]verify block passed.")
+ if _wait_for_airflow_pods(namespace, release_name, timeout, env) != 0:
Review Comment:
I agree that separate timeouts can make the total wait longer than expected.
I kept the existing timeout behavior and documented the extra budget as you
suggested.
The docs now explain that each resource check and the pod-health check get
separate timeouts.
I also added a 900-second example for two resources with a 300-second
timeout. The Helm docs build passed. Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
