ucaeon commented on PR #73591: URL: https://github.com/apache/airflow/pull/73591#issuecomment-6260732969
> Thanks. Checking the Airflow pods themselves after applying an overlay is a good addition. I rebased the branch onto current `main` (the only conflict was the generated `output_k8s.txt` hash, which I regenerated). As it stands, though, the new gate looks likely to fail runs where every live component is healthy, so a few changes are needed. Suggestions are inline. I checked them locally against the PR's tests plus a few ad-hoc cases (evicted pod, failed Job attempt, `CrashLoopBackOff`, dry-run, a failing `kubectl`). With the retry suggestion, `test_query_failure_fails_health_check` needs updating, since a failing `kubectl get pods` is now retried until the deadline instead of failing at once. > > Two places outside the diff also need updating for the new gate: > > * the `--promote-status` help text still says green means "verify block + per-overlay pytest both pass" (and the help images after that); > * the step-by-step comment for the smoke-test step in `.github/workflows/kustomize-overlays-tests.yml` doesn't mention the pod-health step. > > Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting @potiuk I've updated the --promote-status help text and regenerated the help images. The workflow comment now includes the pod-health check. Static checks and the Helm docs build passed. All 63 targeted tests passed along with the full Kerberos smoke test on KinD. Thanks for the review! ☺️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
