ucaeon commented on code in PR #73591:
URL: https://github.com/apache/airflow/pull/73591#discussion_r4310733295
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_kustomize_commands.py:
##########
@@ -279,6 +280,61 @@ def _wait_for_verify_resource(
return 1
+def _get_pod_health_problems(pods: list[dict[str, Any]]) -> list[str]:
+ problems = []
+ for pod in pods:
+ name = pod["metadata"]["name"]
+ status = pod.get("status", {})
+ phase = status.get("phase", "Unknown")
+ if pod["metadata"].get("deletionTimestamp"):
+ problems.append(f"{name}: terminating")
+ elif phase == "Succeeded":
+ continue
Review Comment:
Thanks for pointing this out! 😊
I agree that old failures should not cause a healthy deployment to fail the
check.
I followed your suggestion to ignore evicted pods and failed Job attempts
while still reporting bare failed pods. I also required at least one running
ready pod so an environment with only ignored failures cannot pass.
The regression tests and the full Kerberos smoke test on KinD both passed.
Thanks again for the helpful feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
