ChickenBenny commented on code in PR #75387:
URL: https://github.com/apache/airflow/pull/75387#discussion_r4412864251


##########
task-sdk/src/airflow/sdk/execution_time/schema/versions/v2027_02_28.py:
##########


Review Comment:
   You're right, nothing reads it yet in this PR. I tried dropping the SDK 
bumps, but they're tied to the schema change. `StartupDetails` carries the same 
`TIRunContext`, so once the field is there the supervisor schema changes and 
needs a new version, since `2026-10-30` already shipped in 3.4.0 without it. 
The sync hooks then copy the new schema into the Go and TS SDKs on every 
commit, so their version has to follow.
   
   The only way around it is a separate run-context model for `StartupDetails` 
without the field, but the Go/TS follow-ups would remove it again, since the 
runtimes will read `ti_context.execution_timeout` for their own timeout 
(#74717). So I'd rather keep it as is, unless you prefer the separate model for 
now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to