uranusjr commented on code in PR #75387:
URL: https://github.com/apache/airflow/pull/75387#discussion_r4411039160
##########
task-sdk/src/airflow/sdk/coordinators/_subprocess.py:
##########
@@ -422,7 +422,7 @@ def _on_child_started(
bundle_info=bundle_info,
sentry_integration=sentry_integration,
)
- # Language runtimes do not send StartExecutionTimeout, so the clock
starts once they have the task.
+ # Language runtimes do not send SetExecutionTimeout, so the clock
starts once they have the task.
Review Comment:
The base `ActivitySubprocess._on_child_started` still sets
`self._execution_timeout_seconds = ti_context.execution_timeout`. That value is
only meaningful for this subclass now, so maybe move the assignment here next
to `_arm_execution_timeout()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
