uranusjr commented on code in PR #75387:
URL: https://github.com/apache/airflow/pull/75387#discussion_r4421625687
##########
task-sdk/src/airflow/sdk/coordinators/_subprocess.py:
##########
@@ -579,6 +580,7 @@ def _prepare_ti_context(self, ti: TaskInstance, ti_context:
TIRunContext) -> TIR
)
self.kill(signal.SIGKILL)
return None
+ self._execution_timeout_seconds = ti_context.execution_timeout
Review Comment:
Nit: this assignment is easy to miss after the XCom loop, and it is the only
reason the docstring needs an additional sentence. Move it to the top of
`_prepare_ti_context` and drop the docstring change. A failed delete kills the
process either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
