shivaam commented on code in PR #75387:
URL: https://github.com/apache/airflow/pull/75387#discussion_r4429126320
##########
task-sdk/src/airflow/sdk/coordinators/_subprocess.py:
##########
@@ -546,7 +546,7 @@ def _on_child_started(
bundle_info=bundle_info,
sentry_integration=sentry_integration,
)
- # Language runtimes do not send StartExecutionTimeout, so the clock
starts once they have the task.
+ # Language runtimes do not send SetExecutionTimeout, so the clock
starts once they have the task.
Review Comment:
Accurate for now, but follow-ups 2 and 3 have the Go and TS runtimes send
`SetExecutionTimeout` right before the task runs. This class already handles
that: it inherits the handler, which restarts the deadline from the message.
Maybe word it so it stays true after the follow-ups?
```python
# A language runtime may not send SetExecutionTimeout, so the clock starts
once it has the task.
# If the runtime sends it, the clock restarts from that message.
```
---
Drafted-by: Claude Code (Opus 5.5) (reviewed by Shivaam before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
