potiuk commented on code in PR #76136:
URL: https://github.com/apache/airflow/pull/76136#discussion_r4432048291
##########
dev/breeze/src/airflow_breeze/utils/ci_audit.py:
##########
@@ -327,6 +342,28 @@ def run_audit(*, run: Runner, config: GateConfig,
collaborators: frozenset[str])
enable,
)
)
+ elif actions is not None and not _ok(actions):
+ results.append(
+ CheckResult(
+ 5,
+ "fork workflows",
+ CheckStatus.INFO,
+ f"could not check the GitHub Actions settings of {fork}: "
+ f"{(actions.stderr or '').strip() or 'gh api failed'}",
+ )
+ )
+ elif actions is not None and (actions_problem :=
get_actions_problem(_out(actions), fork)):
Review Comment:
Good catch, you're right. With the `elif` chain, an inactive (or unreadable)
workflow hid a confirmed Actions problem. Pushed a fix: the Actions settings
are now read up front and reported whatever the workflow state. When both are
wrong, the finding names both, and the fix commands enable Actions before
enabling the workflow. Added tests for the inactive, missing and unreadable
workflow cases with Actions disabled.
---
Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
