justinpakzad commented on code in PR #76136:
URL: https://github.com/apache/airflow/pull/76136#discussion_r4431981391
##########
dev/breeze/src/airflow_breeze/utils/ci_audit.py:
##########
@@ -327,6 +342,28 @@ def run_audit(*, run: Runner, config: GateConfig,
collaborators: frozenset[str])
enable,
)
)
+ elif actions is not None and not _ok(actions):
+ results.append(
+ CheckResult(
+ 5,
+ "fork workflows",
+ CheckStatus.INFO,
+ f"could not check the GitHub Actions settings of {fork}: "
+ f"{(actions.stderr or '').strip() or 'gh api failed'}",
+ )
+ )
+ elif actions is not None and (actions_problem :=
get_actions_problem(_out(actions), fork)):
Review Comment:
This might be an edge case but if the workflow isn't active AND actions is
disabled in the fork, would this branch hit? The `state != "active"` above
(332) would match first and since this is an `elif` the problem wouldn't be
reported or fixed on that run, only on a second run if the workflow was
enabled. IIUC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
