vsoch commented on a change in pull request #7191: [AIRFLOW-4030] second attempt to add singularity to airflow URL: https://github.com/apache/airflow/pull/7191#discussion_r368762478
########## File path: tests/contrib/operators/test_singularity_operator.py ########## @@ -0,0 +1,180 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import unittest +import six + +from parameterized import parameterized +from spython.instance import Instance +from airflow import AirflowException + +try: + from airflow.contrib.operators.singularity_operator import SingularityOperator +except ImportError: + pass Review comment: Ah yes, I see the difference between newline and end of line, and also the reasons for the pre-commit run not detecting files, thanks for the clarification! And for the container build, haha. I should expect this sort of thing. Thankfully I could just use the CI output to debug and fix the issues, so the static checks and docs are all good now. The issue remaining is my last post - the fact that we cannot test the singularity operator without installing Singularity, which is a non trivial thing to do on travis (you usually need a machine base with a lot of custom libraries and GoLang). Please let me know how to proceed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
