potiuk edited a comment on issue #7191: [AIRFLOW-4030] second attempt to add singularity to airflow URL: https://github.com/apache/airflow/pull/7191#issuecomment-576470784 > The linting appears to be all set, but since Singularity is installed, the tests are obviously going to fail. Let me know how you would like to proceed - it's a non trivial thing to get Singularity installed from within Travis. I don't think we have enough singularity experience to add it. We approached in various ways for other integrations: - some of the integrations (mongo etc.) are installed as docker-compose images (for example here: https://github.com/apache/airflow/blob/master/scripts/ci/docker-compose/integration-mongo.yml) - some of them (Kubernetes) are installed via kind (Kubernetes-in-Docker) - here: https://github.com/apache/airflow/blob/master/scripts/ci/in_container/kubernetes/setup_kind_cluster.sh - some of them we install inside the docker container via regular Dockerfile image build instructions (minicluster/hive/hadoop) - https://github.com/apache/airflow/blob/3730c24c41470cd331c5109539ee2fa0c9f4e74a/Dockerfile#L152 https://github.com/apache/airflow/blob/master/Dockerfile#L185 I do not know if/whether any of such options is possible for Singularity - please take a look and see if this is possible to use either of the options above? If we find integration too difficult - In a number cases we rely on "unit tests" where we mock the external systems and mark the integration tests as skipped - we have a custom marker `pytest.mark.integration` that does it: https://github.com/apache/airflow/blob/master/TESTING.rst#running-integration-tests . If you have `pytest.mark.integration("singularity")` as decorator, the test will be skipped unless you have INTEGRATION_SINGULARITY env variable defined. You can leave such tests in the code and manually test it when you have singularity (but it's best if we can figure out a way to add it to the docker-compose we are already running).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
