turbaszek commented on a change in pull request #7806: Decouple DAG from DagBag - remove cyclic imports URL: https://github.com/apache/airflow/pull/7806#discussion_r396113970
########## File path: airflow/api/common/experimental/__init__.py ########## @@ -21,7 +21,8 @@ from airflow.configuration import conf from airflow.exceptions import DagNotFound, DagRunNotFound, TaskNotFound -from airflow.models import DagBag, DagModel, DagRun +from airflow.models import DagModel, DagRun Review comment: Should we use explicit imports? ```suggestion from airflow.models.dag import DagModel from airflow.models.dag_run import DagRun ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
