turbaszek commented on a change in pull request #7806: Decouple DAG from DagBag - remove cyclic imports URL: https://github.com/apache/airflow/pull/7806#discussion_r396114432
########## File path: airflow/utils/cycle_tester.py ########## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from collections import defaultdict + +from airflow.exceptions import AirflowDagCycleException + +CYCLE_NEW = 0 +CYCLE_IN_PROGRESS = 1 +CYCLE_DONE = 2 + + +def test_cycle(dag): + """ + Check to see if there are any cycles in the DAG. Returns False if no cycle found, + otherwise raises exception. + """ + def _test_cycle_helper(visit_map, task_id): + """ + Checks if a cycle exists from the input task using DFS traversal + """ + # print('Inspecting %s' % task_id) Review comment: ```suggestion ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
