ryanahamilton commented on a change in pull request #8218: CSS linting 
integrated into pre-commit
URL: https://github.com/apache/airflow/pull/8218#discussion_r405826983
 
 

 ##########
 File path: airflow/www/package.json
 ##########
 @@ -51,6 +51,8 @@
     "mini-css-extract-plugin": "^0.4.1",
     "moment-locales-webpack-plugin": "^1.2.0",
     "style-loader": "^0.21.0",
+    "stylelint": "^13.3.0",
 
 Review comment:
   Are developers running pre-commit in their development environment (I'm not. 
Is that a thing?)? (I'm not well versed in pre-commit.)
   
   I suppose it isn't technically required—though as a developer, I want to be 
checking against these requirements before making any local commits, and 
utilize the package in CLI and in conjunction with my IDE plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to