mik-laj commented on a change in pull request #8218: CSS linting integrated
into pre-commit
URL: https://github.com/apache/airflow/pull/8218#discussion_r405830482
##########
File path: airflow/www/package.json
##########
@@ -51,6 +51,8 @@
"mini-css-extract-plugin": "^0.4.1",
"moment-locales-webpack-plugin": "^1.2.0",
"style-loader": "^0.21.0",
+ "stylelint": "^13.3.0",
Review comment:
Pre-commit downloads and installs the node Most developers use pre-commit
because it is checked in Travis. Without checking changes by pre-commit it
cannot be accepted.
https://github.com/pre-commit/pre-commit/blob/master/pre_commit/languages/node.py#L59
I am only afraid that if you have the same app in two places, they may
behave differently due to additional dependencies. The pre-commit should also
integrate with the IDE because the IDE uses git, but I don't use git in the IDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
