mik-laj commented on a change in pull request #8218: CSS linting integrated
into pre-commit
URL: https://github.com/apache/airflow/pull/8218#discussion_r405833137
##########
File path: airflow/www/package.json
##########
@@ -51,6 +51,8 @@
"mini-css-extract-plugin": "^0.4.1",
"moment-locales-webpack-plugin": "^1.2.0",
"style-loader": "^0.21.0",
+ "stylelint": "^13.3.0",
Review comment:
Generally, this frontend is not intensively developed and it is possible
that we need more advanced solutions, e.g. installing the node in Breeze and
then starting the stylelint by breeze.
https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L195-L200
https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L223-L229
https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L336-L362
However, I have no opinion on this matter. If you prefer to have packages in
package.json, this will ok for me, but it's worth adding a comment that we
should keep two places in sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
