xinbinhuang commented on a change in pull request #8888:
URL: https://github.com/apache/airflow/pull/8888#discussion_r426209091
##########
File path: tests/test_utils/amazon_system_helpers.py
##########
@@ -51,6 +54,27 @@ def provide_aws_s3_bucket(name):
@pytest.mark.system("amazon")
class AmazonSystemTest(SystemTest):
+ @staticmethod
+ def _region_name():
+ return os.environ.get("REGION_NAME")
+
+ @staticmethod
+ def _registry_id():
+ return os.environ.get("REGISTRY_ID")
+
+ @staticmethod
+ def _repository_name():
+ return os.environ.get("REPOSITORY_NAME")
+
+ @staticmethod
+ def _execution_role_arn():
+ return os.environ.get("EXECUTION_ROLE_ARN")
Review comment:
`@property` is not necessarily used to return `self._x`. IMHO,
`@property` fits better here because the names and functionalities are pretty
much attributes access here (though it is getting from the `ENV`).
I think this is more about a design decision, and better stay consistent
across the codebase. I am not sure how other places are using this, so I think
@mik-laj @potiuk @ashb can give better suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
