[
https://issues.apache.org/jira/browse/AIRFLOW-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111146#comment-17111146
]
ASF GitHub Bot commented on AIRFLOW-6983:
-----------------------------------------
ashb commented on pull request #7622:
URL: https://github.com/apache/airflow/pull/7622#issuecomment-630797875
@Khrol Did you test it globally? Including in the webserver? And by the CLI
to you mean anything launched as a subcommand from `airflow` -- cos that is
pretty global :grin:
I _suspect_ that SingletonThreadPool is strictly better in all cases,
including the webserver, but I haven't thought about all the edge cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Disabled connection pool in CLI might be harmful
> ------------------------------------------------
>
> Key: AIRFLOW-6983
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6983
> Project: Apache Airflow
> Issue Type: Improvement
> Components: database
> Affects Versions: 1.10.9
> Reporter: Igor Khrol
> Assignee: Igor Khrol
> Priority: Trivial
>
> Tasks are executed in CLI mode when connection pool to the database is
> disabled.
> `settings.configure_orm(disable_connection_pool=True)`
>
> While one task is run, multiple DB communications are happening while a
> separate connection is allocated for each of them.
>
> It results in DB failures.
>
> Default behavior might be ok but it worth making it configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
