[
https://issues.apache.org/jira/browse/AIRFLOW-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112821#comment-17112821
]
ASF GitHub Bot commented on AIRFLOW-6983:
-----------------------------------------
Khrol commented on a change in pull request #7622:
URL: https://github.com/apache/airflow/pull/7622#discussion_r428460044
##########
File path: airflow/settings.py
##########
@@ -148,18 +148,6 @@ def configure_orm(disable_connection_pool=False):
# 0 means no limit, which could lead to exceeding the Database
connection limit.
pool_size = conf.getint('core', 'SQL_ALCHEMY_POOL_SIZE', fallback=5)
Review comment:
https://docs.sqlalchemy.org/en/13/core/pooling.html#sqlalchemy.pool.SingletonThreadPool
`SingletonThreadPool` has `pool_size` parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Disabled connection pool in CLI might be harmful
> ------------------------------------------------
>
> Key: AIRFLOW-6983
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6983
> Project: Apache Airflow
> Issue Type: Improvement
> Components: database
> Affects Versions: 1.10.9
> Reporter: Igor Khrol
> Assignee: Igor Khrol
> Priority: Trivial
>
> Tasks are executed in CLI mode when connection pool to the database is
> disabled.
> `settings.configure_orm(disable_connection_pool=True)`
>
> While one task is run, multiple DB communications are happening while a
> separate connection is allocated for each of them.
>
> It results in DB failures.
>
> Default behavior might be ok but it worth making it configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
