[ 
https://issues.apache.org/jira/browse/AIRFLOW-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112822#comment-17112822
 ] 

ASF GitHub Bot commented on AIRFLOW-6983:
-----------------------------------------

Khrol commented on pull request #7622:
URL: https://github.com/apache/airflow/pull/7622#issuecomment-631898187


   
https://docs.sqlalchemy.org/en/13/core/pooling.html#sqlalchemy.pool.SingletonThreadPool
   
   ```
   SingletonThreadPool may be improved in a future release, however in its 
current status it is generally used only for test scenarios using a SQLite 
:memory: database and is not recommended for production use.
   ```
   
   I'm a bit worried about this warning.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Disabled connection pool in CLI might be harmful
> ------------------------------------------------
>
>                 Key: AIRFLOW-6983
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6983
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: database
>    Affects Versions: 1.10.9
>            Reporter: Igor Khrol
>            Assignee: Igor Khrol
>            Priority: Trivial
>
> Tasks are executed in CLI mode when connection pool to the database is 
> disabled.
> `settings.configure_orm(disable_connection_pool=True)`
>  
> While one task is run, multiple DB communications are happening while a 
> separate connection is allocated for each of them.
>  
> It results in DB failures.
>  
> Default behavior might be ok but it worth making it configurable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to