[
https://issues.apache.org/jira/browse/AIRFLOW-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564269#comment-16564269
]
ASF GitHub Bot commented on AIRFLOW-2814:
-----------------------------------------
kaxil opened a new pull request #3669: Revert [AIRFLOW-2814] - Change
`min_file_process_interval` to 0
URL: https://github.com/apache/incubator-airflow/pull/3669
Make sure you have checked _all_ steps below.
### JIRA
- [x] My PR addresses the following [Airflow
JIRA](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend
your commit with \[AIRFLOW-XXX\], code changes always need a JIRA issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Default Arg "file_process_interval" for class SchedulerJob is inconsistent
> with doc
> -----------------------------------------------------------------------------------
>
> Key: AIRFLOW-2814
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2814
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Critical
> Fix For: 2.0.0
>
>
> h2. Backgrond
> In
> [https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/jobs.py#L592]
> , it was mentioned the default value of argument *file_process_interval*
> should be 3 minutes (*file_process_interval:* Parse and schedule each file no
> faster than this interval).
> The value is normally parsed from the default configuration. However, in the
> default config_template, its value is 0 rather than 180 seconds
> ([https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/config_templates/default_airflow.cfg#L432]
> ).
> h2. Issue
> This means that actually that each file is parsed and scheduled without
> letting Airflow "rest". This conflicts with the design purpose (by default
> let it be 180 seconds) and may affect performance significantly.
> h2. My Proposal
> Change the value in the config template from 0 to 180.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
