[
https://issues.apache.org/jira/browse/AIRFLOW-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564491#comment-16564491
]
ASF GitHub Bot commented on AIRFLOW-2814:
-----------------------------------------
XD-DENG commented on issue #3659: [AIRFLOW-2814] Fix inconsistent default config
URL:
https://github.com/apache/incubator-airflow/pull/3659#issuecomment-409398992
Hi all, thanks for the inputs. Agree with you on the desired value as well
(the objective of this PR was to fix inconsistency between `.cfg` and comment
in `jobs.py`, instead of proposing another value for this configuration item).
Hi @kaxil , regarding `dag_dir_list_interval`, personally I think it should
be reduced. 5 minutes is quite long for users to wait until new DAG file is
reflected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Default Arg "file_process_interval" for class SchedulerJob is inconsistent
> with doc
> -----------------------------------------------------------------------------------
>
> Key: AIRFLOW-2814
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2814
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Critical
> Fix For: 2.0.0
>
>
> h2. Backgrond
> In
> [https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/jobs.py#L592]
> , it was mentioned the default value of argument *file_process_interval*
> should be 3 minutes (*file_process_interval:* Parse and schedule each file no
> faster than this interval).
> The value is normally parsed from the default configuration. However, in the
> default config_template, its value is 0 rather than 180 seconds
> ([https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/config_templates/default_airflow.cfg#L432]
> ).
> h2. Issue
> This means that actually that each file is parsed and scheduled without
> letting Airflow "rest". This conflicts with the design purpose (by default
> let it be 180 seconds) and may affect performance significantly.
> h2. My Proposal
> Change the value in the config template from 0 to 180.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
