[ 
https://issues.apache.org/jira/browse/AIRFLOW-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564400#comment-16564400
 ] 

ASF GitHub Bot commented on AIRFLOW-2814:
-----------------------------------------

XD-DENG commented on issue #3669: Revert [AIRFLOW-2814] - Change 
`min_file_process_interval` to 0
URL: 
https://github.com/apache/incubator-airflow/pull/3669#issuecomment-409378082
 
 
   Hi @kaxil , please be reminded to update the comment in 
   https://github.com/apache/incubator-airflow/blob/master/airflow/jobs.py#L592 
as well, otherwise the comment will be inconsistent with the configuration 
value again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Default Arg "file_process_interval" for class SchedulerJob is inconsistent 
> with doc
> -----------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-2814
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2814
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> h2. Backgrond
> In 
> [https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/jobs.py#L592]
>  , it was mentioned the default value of argument *file_process_interval* 
> should be 3 minutes (*file_process_interval:* Parse and schedule each file no 
> faster than this interval).
> The value is normally parsed from the default configuration. However, in the 
> default config_template, its value is 0 rather than 180 seconds 
> ([https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/config_templates/default_airflow.cfg#L432]
>  ). 
> h2. Issue
> This means that actually that each file is parsed and scheduled without 
> letting Airflow "rest". This conflicts with the design purpose (by default 
> let it be 180 seconds) and may affect performance significantly.
> h2. My Proposal
> Change the value in the config template from 0 to 180.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to