xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache
parameter in BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r211634204
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -656,6 +671,10 @@ def run_query(self,
configuration['query'][
'schemaUpdateOptions'] = schema_update_options
+ if 'configuration' in api_resource_configs:
Review comment:
I thought about this param like a possibility to set any settings in one
dict, that supported by API (because of 'src_fmt_configs'). For example,
'jobReference' or 'statistics':
https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs. But if we say
what it's only the way to set 'configuration' so it's not needed. What do you
think? Use it only for 'configuration' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
