xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs' URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r212466137
########## File path: airflow/contrib/hooks/bigquery_hook.py ########## @@ -656,6 +668,21 @@ def run_query(self, configuration['query'][ 'schemaUpdateOptions'] = schema_update_options + if not api_resource_configs: + api_resource_configs = self.api_resource_configs + + if 'configuration' in api_resource_configs and isinstance( Review comment: Do you mean first do a copy of api_config in configuration and then add other params to configuration if they do not exist? Am I right understand? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services