xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache
parameter in BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r212444862
##########
File path: tests/contrib/hooks/test_bigquery_hook.py
##########
@@ -281,6 +281,18 @@ def test_run_query_sql_dialect_override(self,
run_with_config):
args, kwargs = run_with_config.call_args
self.assertIs(args[0]['query']['useLegacySql'], bool_val)
+ @mock.patch.object(hook.BigQueryBaseCursor, 'run_with_configuration')
+ def test_api_resource_configs(self, run_with_config):
+ for bool_val in [True, False]:
+ cursor = hook.BigQueryBaseCursor(mock.Mock(), "project_id")
+ cursor.run_query('query',
+ api_resource_configs={
+ 'configuration':
+ {'query': {'useQueryCache': bool_val}}})
+
+ args, kwargs = run_with_config.call_args
+ self.assertIs(args[0]['query']['useQueryCache'], bool_val)
Review comment:
and added check that default values exist and were not delete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
