xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache
parameter in BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r213858150
##########
File path: airflow/contrib/operators/bigquery_operator.py
##########
@@ -64,8 +64,9 @@ class BigQueryOperator(BaseOperator):
:param udf_config: The User Defined Function configuration for the query.
See https://cloud.google.com/bigquery/user-defined-functions for
details.
:type udf_config: list
- :param use_legacy_sql: Whether to use legacy SQL (true) or standard SQL
(false).
- :type use_legacy_sql: boolean
+ :param use_legacy_sql: Whether to use legacy SQL (true) or
+ standard SQL (false).
+ :type use_legacy_sql: booleanq
Review comment:
Yeah, I will change it. I broke my mind with error in test with bql
deprecated warning. It ok in python 3.5, but error with python 2.7.. but it’s
not errored before, not failed on master branch, but I did not touch warning or
test... I try to fix it several days, must fun the fact, what in my local env
this test always failed with python 2.7 (master too)... aaaaaaaa panic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
