Fokko commented on a change in pull request #3981: [AIRFLOW-3133] Implement
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r224664626
##########
File path: airflow/contrib/operators/jenkins_job_trigger_operator.py
##########
@@ -243,7 +247,9 @@ def execute(self, context):
'this exception for unknown parameters'
'You can also check logs for more details on this
exception '
'(jenkins_url/log/rss)', str(err))
- if build_info:
- # If we can we return the url of the job
- # for later use (like retrieving an artifact)
- return build_info['url']
+
+ if self.do_xcom_push:
Review comment:
Please collapse this into a single if `if self.do_xcom_push && build_info`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services