Fokko commented on a change in pull request #3981: [AIRFLOW-3133] Implement 
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r224664588
 
 

 ##########
 File path: airflow/contrib/operators/gcs_to_s3.py
 ##########
 @@ -88,11 +91,17 @@ def __init__(self,
         self.dest_s3_key = dest_s3_key
         self.dest_verify = dest_verify
         self.replace = replace
+        self.do_xcom_push = do_xcom_push
 
     def execute(self, context):
+        # this operator calls super and uses the returned value, so we set 
do_xcom_push to
 
 Review comment:
   This is nasty, we should be able to return this, or pass the `do_xcom_push` 
to the super.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to