Fokko commented on a change in pull request #3981: [AIRFLOW-3133] Implement
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r224665405
##########
File path: airflow/contrib/operators/bigquery_get_data.py
##########
@@ -78,6 +80,7 @@ def __init__(self,
selected_fields=None,
bigquery_conn_id='bigquery_default',
delegate_to=None,
+ do_xcom_push=True,
Review comment:
@XD-DENG I fully agree. It would be even nicer to add the logic somewhere
around here:
https://github.com/apache/incubator-airflow/blob/b85210d8596c1e05fbf3da2941aaca8170ae871e/airflow/models.py#L1643
Instead of duplicating it in every operator. This makes it very easy for
newcomers to forget about xcom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
