Yao-MR commented on code in PR #2715:
URL: https://github.com/apache/incubator-amoro/pull/2715#discussion_r1554834104
##########
ams/server/src/main/java/com/netease/arctic/server/DefaultOptimizingService.java:
##########
@@ -548,6 +548,7 @@ public void run() {
.forEach(task -> retryTask(task, queue)));
if (isExpired) {
LOG.info("Optimizer {} has been expired, unregister it",
keepingTask.getOptimizer());
+ deleteResource(keepingTask.getOptimizer().getResourceId());
Review Comment:
the createResource is actually called by user,
and the deleteResource is also will be called by user, if user want the
release the optimzier,
but if the optimizer instance failed by some unexpected casuse, the system
will delete the instance auto, but will
not clean the resource record in the record, and this resource will never be
used again and will cause dead dirty data in the db forever.
so when the instance is expired and be deleted by system, the resource
associate with this instance should also be cleand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
