zhoujinsong commented on PR #2715:
URL: https://github.com/apache/incubator-amoro/pull/2715#issuecomment-2042108768

   @Yao-MR Thanks a lot for driving this improvement.
   
   I have some questions about this PR:
   
   - The resource id of the optimizer may be null, you may want to consider the 
situation.
   - The optimizer may reconnect to the AMS even if the token is expired, and 
it will request a new token with the same resource id. So it may be dangerous 
to delete the resources as soon as the token expires.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to