majin1102 commented on code in PR #2715:
URL: https://github.com/apache/amoro/pull/2715#discussion_r1558036625
##########
ams/server/src/main/java/com/netease/arctic/server/DefaultOptimizingService.java:
##########
@@ -548,6 +548,7 @@ public void run() {
.forEach(task -> retryTask(task, queue)));
if (isExpired) {
LOG.info("Optimizer {} has been expired, unregister it",
keepingTask.getOptimizer());
+ deleteResource(keepingTask.getOptimizer().getResourceId());
Review Comment:
I don't quite agree with that.
The record left in db has its meaning, cause when the optimizer came back,
AMS could identify this resource.
What you said I think is a dashboard design issue, the optimizer page don't
reveal inactive optimizers. I think we could improve in that way.
A good and simple princeple is who creates who deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
